Re: [Qemu-devel] [PATCH 0/5] VMState cleanups

[Peter Maydell]

On 22 February 2012 10:15, Igor Mitsyanko <address@hidden> wrote:
> Patch 4 moves VMSTATE_UINTTL from hw.h to vmstate.h. Explicit dependency
> on NEED_CPU_H is droped, I failed to understand why it was presented at all.

You need #ifdef NEED_CPU_H because in generic source files (where NEED_CPU_H
is not defined) there is no TARGET_LONG_BITS or target_ulong because you
don't know how wide the target CPU virtual addresses are. Only in the
source files which are compiled for a specific CPU virtual address size
is NEED_CPU_H defined. There's no point in defining these macros in
contexts where they can't possibly be used.

(This dependence on the CPU vaddr width is why I like the idea of just
sticking them in target-i386...)

-- PMM