[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/5] VMState cleanups
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 0/5] VMState cleanups |
Date: |
Wed, 22 Feb 2012 12:50:49 +0000 |
On 22 February 2012 12:49, Andreas Färber <address@hidden> wrote:
> Am 22.02.2012 12:26, schrieb Peter Maydell:
>> So if we apply patches 1-3 (which all look plausible) then the only
>> remaining user of VMSTATE_UINTTL is target-i386/machine.c as far as
>> I can see.
>>
>> This leaves me wondering if we shouldn't just put it actually in
>> target-i386/machine.c as a convenience macro for that specific CPU
>> to avoid having to have more #ifdef TARGET_X86_64s.
>
> Nack. I don't see the connection between target_ulong and TARGET_X86_64.
> Just because that becomes the only user does not mean target_ulong is an
> x86-specific concept.
Yeah, I guess. I would like the macro to be protected so you can only
get at it if you're target-*/ though...
-- PMM
- Re: [Qemu-devel] [PATCH 3/5] hw/pxa2xx_lcd.c: drop VMSTATE_UINTTL usage, (continued)
- [Qemu-devel] [PATCH 1/5] target-alpha/machine.c: use VMSTATE_UINT64* instead of VMSTATE_UINTTL*, Igor Mitsyanko, 2012/02/22
- [Qemu-devel] [PATCH 4/5] vmstate: refactor and move VMSTATE_UINTTL* macro, Igor Mitsyanko, 2012/02/22
- [Qemu-devel] [PATCH 5/5] vmstate: introduce get_bufsize entry in VMStateField, Igor Mitsyanko, 2012/02/22
- Re: [Qemu-devel] [PATCH 0/5] VMState cleanups, Peter Maydell, 2012/02/22
- Re: [Qemu-devel] [PATCH 0/5] VMState cleanups, Mitsyanko Igor, 2012/02/22
- Re: [Qemu-devel] [PATCH 0/5] VMState cleanups, Andreas Färber, 2012/02/22
- Re: [Qemu-devel] [PATCH 0/5] VMState cleanups,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH 0/5] VMState cleanups, Juan Quintela, 2012/02/22
- Re: [Qemu-devel] [PATCH 0/5] VMState cleanups, Andreas Färber, 2012/02/22
- Re: [Qemu-devel] [PATCH 0/5] VMState cleanups, Peter Maydell, 2012/02/22
- Re: [Qemu-devel] [PATCH 0/5] VMState cleanups, Andreas Färber, 2012/02/22
- Re: [Qemu-devel] [PATCH 0/5] VMState cleanups, Peter Maydell, 2012/02/22
- Re: [Qemu-devel] [PATCH 0/5] VMState cleanups, Alexander Graf, 2012/02/22
- Re: [Qemu-devel] [PATCH 0/5] VMState cleanups, Juan Quintela, 2012/02/23
Re: [Qemu-devel] [PATCH 0/5] VMState cleanups, Peter Maydell, 2012/02/22