[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 7/8] qom: distinguish "legacy" property type nam

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 7/8] qom: distinguish "legacy" property type name from QOM type name
Date: Fri, 16 Dec 2011 08:43:04 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110831 Lightning/1.0b2 Thunderbird/3.1.13

On 12/16/2011 08:18 AM, Paolo Bonzini wrote:
On 12/16/2011 03:06 PM, Anthony Liguori wrote:

- type = g_strdup_printf("legacy<%s>", prop->info->name);
+ type = g_strdup_printf("legacy<%s>",
+ prop->info->legacy_name ?: prop->info->name);

I think this confuses the legacy type with the legacy property names.

I think it would be better to do 'legacy-%s' as then it's at least clear
when something is a type name vs. a property name.

That's only in 8/8. Here I'm not changing property names yet, note that
everything is in prop->info.

This patch prepares for when you'll have a legacy<hex32> type for property
legacy<iobase>, and uint32 for iobase. But I can surely rename legacy<iobase> to
legacy-iobase, if that's what you meant.

No, I got confused.  Ignore my comments.


Anthony Liguori


reply via email to

[Prev in Thread] Current Thread [Next in Thread]