[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/8] qom: fix swapped parameters

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 3/8] qom: fix swapped parameters
Date: Fri, 16 Dec 2011 07:57:58 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110831 Lightning/1.0b2 Thunderbird/3.1.13

On 12/16/2011 06:01 AM, Paolo Bonzini wrote:
Signed-off-by: Paolo Bonzini<address@hidden>

Yeah, this code path is currently dead as there is no way to test it until we defer s/init/realize/ and defer it to guest launch.

In my next series when I introduce Object and move properties into it, we can write some unit tests to cover this sort of thing.

Reviewed-by: Anthony Liguori <address@hidden>


Anthony Liguori

  hw/qdev.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/qdev.c b/hw/qdev.c
index 83913c7..bda8d6c 100644
--- a/hw/qdev.c
+++ b/hw/qdev.c
@@ -1110,7 +1110,7 @@ void qdev_property_set(DeviceState *dev, Visitor *v, 
const char *name,
      if (!prop->set) {
          error_set(errp, QERR_PERMISSION_DENIED);
      } else {
-        prop->set(dev, prop->opaque, v, name, errp);
+        prop->set(dev, v, prop->opaque, name, errp);

reply via email to

[Prev in Thread] Current Thread [Next in Thread]