[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 5/8] qom: introduce QERR_PROPERTY_VALUE_OUT_OF_R

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 5/8] qom: introduce QERR_PROPERTY_VALUE_OUT_OF_RANGE
Date: Fri, 16 Dec 2011 11:01:43 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110831 Lightning/1.0b2 Thunderbird/3.1.13

On 12/16/2011 11:00 AM, Paolo Bonzini wrote:
On 12/16/2011 03:01 PM, Paolo Bonzini wrote:

I'd rather use generic errors when possible. How about
VALUE_OUT_OF_RANGE and we can make the message "'%(item)' doesn't take
value..." and pass "%s.%s" % (device, property) for item.


I didn't do this in the end for two reasons.

First, that it is inconsistent with other errors from qdev properties. Current
master does not raise them when properties are accessed via QOM, but my revised
series does.

Second, that it is actually provides less structured information. There's no
reason why a client should be expected to "know" that %(item) is in that form.

Ok, then Reviewed-by: Anthony Liguori <address@hidden>


Anthony Liguori


reply via email to

[Prev in Thread] Current Thread [Next in Thread]