[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] cvs cpu-exec.c (bug?)

From: Renzo Davoli
Subject: Re: [Qemu-devel] cvs cpu-exec.c (bug?)
Date: Sat, 10 Jul 2004 23:46:25 +0200
User-agent: Mutt/1.3.28i

I have just returned from a conference and I have just checked out the
latest version from the cvs.

My compiler refused to compile the cpu-exec.c without the following
trivial patch, in line 906:

<int cpu_signal_handler(int host_signum, siginfo *info,
<                       void *puc)
>int cpu_signal_handler(int host_signum, struct siginfo *info,
>                       void *puc)

the keyword "struct" is missing defining the argument named info.
Maybe several other compilers have the implicit typedef on structs and
give either no error or just a warning.

For the sake of portability (and consistency, siginfo is always named as
"struct" in the remaining of the code) I feel it should be better to fix

Thanks. Ciao.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]