qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] iotests/check: move general long options to double dash


From: Eric Blake
Subject: Re: [PATCH] iotests/check: move general long options to double dash
Date: Mon, 7 Jun 2021 09:44:18 -0500
User-agent: NeoMutt/20210205

On Fri, Jun 04, 2021 at 11:25:16AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> So, there are some ways to improve the situation:

My personal preference (although I'm fine with any of your listed
options, if others speak up in favor of a different one):

> 2. Take this patch and also convert protocol and format options
> 
> Pros: everything is consistent and use two dashes, so we can safely use 
> combining short options syntax
> Cons: more pain for developers to write --qcow2 instead of -qcow2 every time. 
> What actually stopped me of posting that patch (converting protocol and 
> format options), I imagined the heavy extra load on all block-layer 
> developers right pinky to push '-' one time more :))

I don't mind typing an extra - for './check --qcow2'.  I agree it will
cause some temporary learning curve when I type the short way and it
fails, but as long as the error message is good, I don't see a problem
in changing the interface since this is a developer-only tool.

> So, I'm OK with either way and can make patches. But I don't want to be the 
> only person who makes a decision. So, let's wait for opinions, and if nobody 
> really interested, go the default way [3].

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]