qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] iotests/check: move general long options to double dash


From: Paolo Bonzini
Subject: Re: [PATCH] iotests/check: move general long options to double dash
Date: Thu, 3 Jun 2021 13:38:03 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1

On 26/05/21 20:16, Vladimir Sementsov-Ogievskiy wrote:
So, the change:

   -makecheck -> --makecheck
   -valgrind  -> --valgrind
   -nocache   -> --nocache
   -misalign  -> --misalign

Motivation:

1. Several long options are already have double dash:
   --dry-run, --color, --groups, --exclude-groups, --start-from

2. -misalign is used to add --misalign option (two dashes) to qemu-io

3. qemu-io and qemu-nbd has --nocache option (two dashes)

Just like for QEMU, let me reiterate that this is generally not an improvement.

Double-dash options give extra information to the user that short (single-dash) options can be combined, while this is not the case for iotests/check.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]