qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 05/15] qemu-iotests: delay QMP socket timers


From: Emanuele Giuseppe Esposito
Subject: Re: [PATCH v4 05/15] qemu-iotests: delay QMP socket timers
Date: Thu, 3 Jun 2021 13:03:35 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1



So, you just make the class do nothing.. I'd prefer something like this:

@contextmanager
def NoTimeout:
    yield

if qemu_gdb:
   Timeout = NoTimeout

I am not sure I understand what you want to do here.
I have a basic understanding of @contextmanager, but can you explain more what you want to do?

Alternatively, I send the patch as-is, and then you can send this change.

Thank you,
Emanuele



anyway:

Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>





reply via email to

[Prev in Thread] Current Thread [Next in Thread]