[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 0/2] less confusing block file names

From: Eric Blake
Subject: Re: [Qemu-block] [PATCH 0/2] less confusing block file names
Date: Mon, 24 Oct 2016 14:47:05 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0

On 10/24/2016 10:14 AM, Kevin Wolf wrote:
> Am 24.10.2016 um 16:44 hat Paolo Bonzini geschrieben:
>> On 24/10/2016 15:47, Kevin Wolf wrote:
>>> One effect that makes me less than fully happy is that 'git log
>>> block/raw.c' without --follow mixes the history of the renamed driver
>>> with the history of the old, differently licensed one. On the other
>>> hand, the removal of the old driver happened three years ago, so it's
>>> probably unlikely that people confuse what belongs to which one and
>>> revive old code accidentally.
>> Hmm, this makes it sensible to only apply patch 2, especially since Eric
>> has corteously split them. :)
> Maybe rename to something like raw-format.c instead then in patch 1?

raw-format.c would indeed be a project-unique name; I can respin along
those lines if there is consensus on that front, as well as touch up the
commit message to point out the history of the bsd name (as Laszlo
pointed out, it was the choice of licensing that determined the original

> I must admit that it's reasonable enough to make the assumption that
> raw_bsd.c has something to do with a BSD-specific block driver.
> Kevin

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]