[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 0/2] less confusing block file names

From: Kevin Wolf
Subject: Re: [Qemu-block] [PATCH 0/2] less confusing block file names
Date: Mon, 24 Oct 2016 15:47:50 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Am 20.10.2016 um 03:11 hat Eric Blake geschrieben:
> Based on a suggestion here:
> https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg00350.html
> Eric Blake (2):
>   block: Rename raw_bsd to raw.c
>   block: rename raw-{posix,win32} to file-*.c

Seems to do what it promises:
Reviewed-by: Kevin Wolf <address@hidden>

I'd like to hear a few more opinions on whether it's a good idea, but I
don't think this should stay for too long on the list because we already
have conflicting patches.

One effect that makes me less than fully happy is that 'git log
block/raw.c' without --follow mixes the history of the renamed driver
with the history of the old, differently licensed one. On the other
hand, the removal of the old driver happened three years ago, so it's
probably unlikely that people confuse what belongs to which one and
revive old code accidentally.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]