[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 0/2] less confusing block file names

From: Eric Blake
Subject: Re: [Qemu-block] [PATCH 0/2] less confusing block file names
Date: Mon, 24 Oct 2016 10:44:18 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0

On 10/24/2016 08:47 AM, Kevin Wolf wrote:
> Am 20.10.2016 um 03:11 hat Eric Blake geschrieben:
>> Based on a suggestion here:
>> https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg00350.html
>> Eric Blake (2):
>>   block: Rename raw_bsd to raw.c
>>   block: rename raw-{posix,win32} to file-*.c
> Seems to do what it promises:
> Reviewed-by: Kevin Wolf <address@hidden>
> I'd like to hear a few more opinions on whether it's a good idea, but I
> don't think this should stay for too long on the list because we already
> have conflicting patches.

On the bright side, git with rename detection enabled is generally able
to patch the correct file, even after a rename.

> One effect that makes me less than fully happy is that 'git log
> block/raw.c' without --follow mixes the history of the renamed driver
> with the history of the old, differently licensed one. On the other
> hand, the removal of the old driver happened three years ago, so it's
> probably unlikely that people confuse what belongs to which one and
> revive old code accidentally.

I guess knowing the history explains the current file name; and as you
mentioned, we're starting to get far enough away from the point the file
was created that the history of the name is less relevant and less
likely to cause mistakes in code motion.  And it's not the first time
we've reused a file name within the tree (look at the history of
top-level qjson.c, which has existed twice before being moved to another
location twice).

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]