[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 03/14] hw/misc/bcm2835_property: Handle the 'domain state
From: |
Esteban Bosse |
Subject: |
Re: [RFC PATCH 03/14] hw/misc/bcm2835_property: Handle the 'domain state' property |
Date: |
Sun, 29 Sep 2019 09:01:19 +0200 |
User-agent: |
Evolution 3.30.5-1.1 |
El mié, 04-09-2019 a las 19:13 +0200, Philippe Mathieu-Daudé escribió:
> The kernel is happy with this change, so we don't need
> to do anything more sophisticated.
>
> Reviewed-by: Peter Maydell <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/misc/bcm2835_property.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/hw/misc/bcm2835_property.c b/hw/misc/bcm2835_property.c
> index 399f0d9dd5..d8eb28f267 100644
> --- a/hw/misc/bcm2835_property.c
> +++ b/hw/misc/bcm2835_property.c
> @@ -127,6 +127,14 @@ static void
> bcm2835_property_mbox_push(BCM2835PropertyState *s, uint32_t value)
> resplen = 8;
> break;
>
> + case 0x00030030: /* Get domain state */
> + qemu_log_mask(LOG_UNIMP,
> + "bcm2835_property: 0x%08x get domain state
> NYI\n",
> + tag);
> + /* FIXME returning uninitialized memory */
> + resplen = 8;
> + break;
> +
> case 0x00038002: /* Set clock rate */
> case 0x00038004: /* Set max clock rate */
> case 0x00038007: /* Set min clock rate */
Searching this property in the kernel, I found a lot of properties not
implemented.
https://github.com/raspberrypi/linux/blob/rpi-4.19.y/include/soc/bcm2835/raspberrypi-firmware.h#L41
Are the properties only added when they are necessaries for the
standard kernel use?
- [Qemu-arm] [RFC PATCH 00/14] hw/arm: Add the Raspberry Pi 4B, Philippe Mathieu-Daudé, 2019/09/04
- [Qemu-arm] [PATCH 01/14] hw/arm/raspi: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2019/09/04
- [Qemu-arm] [PATCH 02/14] hw/misc/bcm2835_property: Add FIXME comment for uninitialized memory, Philippe Mathieu-Daudé, 2019/09/04
- [Qemu-arm] [RFC PATCH 03/14] hw/misc/bcm2835_property: Handle the 'domain state' property, Philippe Mathieu-Daudé, 2019/09/04
- [Qemu-arm] [PATCH 04/14] hw/arm/bcm2835_peripherals: Improve logging, Philippe Mathieu-Daudé, 2019/09/04
- [Qemu-arm] [PATCH 05/14] hw/arm/bcm2835_peripherals: Name various address spaces, Philippe Mathieu-Daudé, 2019/09/04
- [Qemu-arm] [PATCH 06/14] hw/arm/bcm2835: Rename some definitions, Philippe Mathieu-Daudé, 2019/09/04
- [Qemu-arm] [PATCH 08/14] hw/arm/bcm2836: Make the SoC code modular, Philippe Mathieu-Daudé, 2019/09/04
- [Qemu-arm] [PATCH 07/14] hw/arm/bcm2835: Add various unimplemented peripherals, Philippe Mathieu-Daudé, 2019/09/04