[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/14] hw/arm/raspi: Use the IEC binary prefix definitions
From: |
Esteban Bosse |
Subject: |
Re: [PATCH 01/14] hw/arm/raspi: Use the IEC binary prefix definitions |
Date: |
Sun, 29 Sep 2019 08:57:45 +0200 |
User-agent: |
Evolution 3.30.5-1.1 |
El mié, 04-09-2019 a las 19:13 +0200, Philippe Mathieu-Daudé escribió:
> IEC binary prefixes ease code review: the unit is explicit.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/arm/raspi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c
> index 74c062d05e..615d755879 100644
> --- a/hw/arm/raspi.c
> +++ b/hw/arm/raspi.c
> @@ -230,7 +230,7 @@ static void raspi2_machine_init(MachineClass *mc)
> mc->max_cpus = BCM283X_NCPUS;
> mc->min_cpus = BCM283X_NCPUS;
> mc->default_cpus = BCM283X_NCPUS;
> - mc->default_ram_size = 1024 * 1024 * 1024;
> + mc->default_ram_size = 1 * GiB;
> mc->ignore_memory_transaction_failures = true;
> };
> DEFINE_MACHINE("raspi2", raspi2_machine_init)
> @@ -252,7 +252,7 @@ static void raspi3_machine_init(MachineClass *mc)
> mc->max_cpus = BCM283X_NCPUS;
> mc->min_cpus = BCM283X_NCPUS;
> mc->default_cpus = BCM283X_NCPUS;
> - mc->default_ram_size = 1024 * 1024 * 1024;
> + mc->default_ram_size = 1 * GiB;
> }
> DEFINE_MACHINE("raspi3", raspi3_machine_init)
> #endif
Reviewed-by: Esteban Bosse <address@hidden>
- [Qemu-arm] [RFC PATCH 00/14] hw/arm: Add the Raspberry Pi 4B, Philippe Mathieu-Daudé, 2019/09/04
- [Qemu-arm] [PATCH 01/14] hw/arm/raspi: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2019/09/04
- [Qemu-arm] [PATCH 02/14] hw/misc/bcm2835_property: Add FIXME comment for uninitialized memory, Philippe Mathieu-Daudé, 2019/09/04
- [Qemu-arm] [RFC PATCH 03/14] hw/misc/bcm2835_property: Handle the 'domain state' property, Philippe Mathieu-Daudé, 2019/09/04
- [Qemu-arm] [PATCH 04/14] hw/arm/bcm2835_peripherals: Improve logging, Philippe Mathieu-Daudé, 2019/09/04
- [Qemu-arm] [PATCH 05/14] hw/arm/bcm2835_peripherals: Name various address spaces, Philippe Mathieu-Daudé, 2019/09/04
- [Qemu-arm] [PATCH 06/14] hw/arm/bcm2835: Rename some definitions, Philippe Mathieu-Daudé, 2019/09/04