[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-arm] [PATCH 02/14] hw/misc/bcm2835_property: Add FIXME comment for
From: |
Philippe Mathieu-Daudé |
Subject: |
[Qemu-arm] [PATCH 02/14] hw/misc/bcm2835_property: Add FIXME comment for uninitialized memory |
Date: |
Wed, 4 Sep 2019 19:13:03 +0200 |
We are returning unintialized memory, this is probably unsafe.
Reported-by: Peter Maydell <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
hw/misc/bcm2835_property.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/misc/bcm2835_property.c b/hw/misc/bcm2835_property.c
index d86d510572..399f0d9dd5 100644
--- a/hw/misc/bcm2835_property.c
+++ b/hw/misc/bcm2835_property.c
@@ -57,6 +57,7 @@ static void bcm2835_property_mbox_push(BCM2835PropertyState
*s, uint32_t value)
case 0x00010001: /* Get board model */
qemu_log_mask(LOG_UNIMP,
"bcm2835_property: %x get board model NYI\n", tag);
+ /* FIXME returning uninitialized memory */
resplen = 4;
break;
case 0x00010002: /* Get board revision */
@@ -70,6 +71,7 @@ static void bcm2835_property_mbox_push(BCM2835PropertyState
*s, uint32_t value)
case 0x00010004: /* Get board serial */
qemu_log_mask(LOG_UNIMP,
"bcm2835_property: %x get board serial NYI\n", tag);
+ /* FIXME returning uninitialized memory */
resplen = 8;
break;
case 0x00010005: /* Get ARM memory */
--
2.20.1
- [Qemu-arm] [RFC PATCH 00/14] hw/arm: Add the Raspberry Pi 4B, Philippe Mathieu-Daudé, 2019/09/04
- [Qemu-arm] [PATCH 01/14] hw/arm/raspi: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2019/09/04
- [Qemu-arm] [PATCH 02/14] hw/misc/bcm2835_property: Add FIXME comment for uninitialized memory,
Philippe Mathieu-Daudé <=
- [Qemu-arm] [RFC PATCH 03/14] hw/misc/bcm2835_property: Handle the 'domain state' property, Philippe Mathieu-Daudé, 2019/09/04
- [Qemu-arm] [PATCH 04/14] hw/arm/bcm2835_peripherals: Improve logging, Philippe Mathieu-Daudé, 2019/09/04
- [Qemu-arm] [PATCH 05/14] hw/arm/bcm2835_peripherals: Name various address spaces, Philippe Mathieu-Daudé, 2019/09/04
- [Qemu-arm] [PATCH 06/14] hw/arm/bcm2835: Rename some definitions, Philippe Mathieu-Daudé, 2019/09/04
- [Qemu-arm] [PATCH 08/14] hw/arm/bcm2836: Make the SoC code modular, Philippe Mathieu-Daudé, 2019/09/04