Re: pspp removed from Debian

[Ben Pfaff]

The package seems OK enough.  There are several lintian warnings.  Have
you considered fixing some of them?  Some of them would be rather easy.

On Mon, Aug 11, 2014 at 08:31:58AM -0700, Ben Pfaff wrote:
> Great.
> 
> I will try to review the package tonight, with an eye toward uploading
> it.
> 
> On Sun, Aug 10, 2014 at 12:14:24PM +0200, Friedrich Beckmann wrote:
> > Hi,
> > 
> > i uploaded an updated version of the debian package 0.8.3-1 with the 
> > following changes
> > as a result of the lint analysis.
> > 
> > Friedrich 
> > 
> > 
> > ======== diff =========
> > 
> > diff --git a/README.Debian b/README.Debian
> > index 2cb626a..ed4727b 100644
> > --- a/README.Debian
> > +++ b/README.Debian
> > @@ -40,4 +40,4 @@ To use pspp-mode.el, you may want to add something like 
> > this to your .emacs file
> >  
> >             - Jim Van Zandt
> >  
> > - -- Friedrich Beckmann <address@hidden>  Thu, 07 Aug 2014 03:04:58 +0200
> > + -- Friedrich Beckmann <address@hidden>  Thu, 07 Aug 2014 03:04:58 +0200
> > diff --git a/README.source b/README.source
> > index d20ed9e..d5308e9 100644
> > --- a/README.source
> > +++ b/README.source
> > @@ -6,7 +6,7 @@ The source tarball is from http://ftp.gnu.org/gnu/pspp/
> >  This tarball is already processed with autotools and provides the configure
> >  script directly.
> >  
> > - -- Friedrich Beckmann <address@hidden> Fr, 8 Aug 2014
> > + -- Friedrich Beckmann <address@hidden> Fr, 8 Aug 2014
> >  
> >  
> >  
> > diff --git a/changelog b/changelog
> > index e6fb89f..1cfbba7 100644
> > --- a/changelog
> > +++ b/changelog
> > @@ -2,9 +2,9 @@ pspp (0.8.3-1) unstable; urgency=low
> >  
> >    * Non-maintainer upload.
> >    * upgrade to upstream version 0.8.3
> > -  * debian/patches/test1039fix.patch: Add patch to fix a test failure in 
> > sid. The patch is already in pspp upstream version. See 
> > http://git.savannah.gnu.org/cgit/pspp.git/commit/?id=9f3aceccf7a1f7c08312be6cb34aa688bd958677
> > +  * debian/patches/test1039fix.patch: Add patch to fix a test failure in 
> > sid.
> >  
> > - -- Friedrich Beckmann <address@hidden>  Thu, 07 Aug 2014 03:04:58 +0200
> > + -- Friedrich Beckmann <address@hidden>  Thu, 07 Aug 2014 03:04:58 +0200
> >  
> >  pspp (0.7.9+git20120620-1.1) unstable; urgency=low
> >  
> > diff --git a/control b/control
> > index 50f5bbb..1b95979 100644
> > --- a/control
> > +++ b/control
> > @@ -1,7 +1,7 @@
> >  Source: pspp
> >  Section: math
> >  Priority: optional
> > -Maintainer: Friedrich Beckmann <address@hidden>
> > +Maintainer: Friedrich Beckmann <address@hidden>
> >  Uploaders: Ben Pfaff <address@hidden>
> >  Build-Depends: debhelper (>= 9.0.0),
> >                 perl,
> > diff --git a/patches/series b/patches/series
> > index f1d1bfe..6b7c8ba 100644
> > --- a/patches/series
> > +++ b/patches/series
> > @@ -1 +1,2 @@
> > +fix_paths_in_manpage
> >  test1039fix.patch
> > diff --git a/patches/test1039fix.patch b/patches/test1039fix.patch
> > index 4828d5f..2914131 100644
> > --- a/patches/test1039fix.patch
> > +++ b/patches/test1039fix.patch
> > @@ -1,3 +1,9 @@
> > +The patch fixes a test failure which showed up in sid. In sid test 1039 
> > (pspp.t) failed. 
> > +The problem is that the test code depends on the implementation of perl. 
> > +The patch is already in pspp upstream. So the patch can be removed with 
> > the next pspp release. 
> > +This patch is required for pspp 0.8.3. 
> > +See 
> > http://git.savannah.gnu.org/cgit/pspp.git/commit/?id=9f3aceccf7a1f7c08312be6cb34aa688bd958677
> > +
> >  --- a/perl-module/t/Pspp.t
> >  +++ b/perl-module/t/Pspp.t
> >  @@ -374,7 +374,7 @@
> > diff --git a/watch b/watch
> > index 9461c23..f0dd4ac 100644
> > --- a/watch
> > +++ b/watch
> > @@ -11,7 +11,7 @@ version=3
> >  #http://www.example.com/downloads.php pspp-(.*)\.tar\.gz
> >  
> >  # Uncomment to examine a Webserver directory
> > -http://ftp.gnu.org/gnu/pspp-(.*)\.tar\.gz
> > +http://ftp.gnu.org/gnu/pspp/pspp-(.*)\.tar\.gz
> >  
> >  # Uncommment to examine a FTP server
> >  #ftp://ftp.example.com/pub/pspp-(.*)\.tar\.gz debian uupdate
> > Am 10.08.2014 um 01:10 schrieb Friedrich Beckmann <address@hidden>:
> > 
> > > Hi Ben,
> > > 
> > > i just did an upload to mentors.debian.net. The package is here:
> > > 
> > > http://mentors.debian.net/package/pspp
> > > 
> > > Friedrich
> > > 
> > > 
> > 
> > 
> > 
> > 
> > 
> 
> > _______________________________________________
> > pspp-dev mailing list
> > address@hidden
> > https://lists.gnu.org/mailman/listinfo/pspp-dev
>