Re: [Phpgroupware-developers] Submitting Patches

[Daryl L. L. Houston]

D'oh.  Totally missed that.  Thanks.

D


On Thursday 08 May 2003 02:55 pm, Chris Weiss wrote:
> uh, attach them to the patch manager?
>
> Daryl L. L. Houston (address@hidden) wrote:
> >How exactly should I get these onto savannah?  While I added my ssh public
> > key to my account using the Web interface, it doesn't appear that I'm
> > able to ssh in.  I can't sftp in either, and I just tried logging in to
> > the cvs server with no luck.  I'll shoot a note over to the admins at
> > savannah.  Looks like getting these changes in this release may be a lost
> > cause at this point, though, given my tardiness.
> >
> >D
> >
> >On Wednesday 07 May 2003 06:27 pm, Dave Hall wrote:
> >> "Daryl L. L. Houston" <address@hidden> wrote:
> >> > I've got a number of modifications I'd like to submit for review.
> >> > I've worked
> >> > on these off and no over the past two weeks after downloading the
> >> > 9.16 branch
> >> > from CVS.  Work on that branch has continued as I've been making
> >> > my changes.
> >> > Is it still the correct protocol to submit suggested changes by
> >> > using the
> >> > method outlined at http://docs.phpgroupware.org/patches.php?  In
> >> > the example
> >> > given there, the patch would contain diffs of the whole GW
> >> > directory
> >> > structure; this seems inconsistent with the request that patches
> >> > be submitted
> >> > individually.  Which is it?
> >>
> >> Each piece of new functionality should be a seperate patch.
> >>
> >> > Also, I've made a number of separate
> >> > modifications that overlap files.  That is, the addition of
> >> > separate sets of
> >> > functionality has affected the same file; thus submitting a single
> >> > patch
> >> > isn't really workable.  How should I proceed?  Among the additions
> >> > I've made
> >> > are the following:
> >>
> >> Seperate patches would be desirable ... or at least one per app if you
> >> can't do it.  If you get them onto savannah then i will allocate them.
> >> Unfortunately time is short - feature freeze Friday.
> >>
> >> Cheers
> >>
> >> Dave
> >
> >_______________________________________________
> >Phpgroupware-developers mailing list
> >address@hidden
> >http://mail.gnu.org/mailman/listinfo/phpgroupware-developers
>
> _______________________________________________
> Phpgroupware-developers mailing list
> address@hidden
> http://mail.gnu.org/mailman/listinfo/phpgroupware-developers