RE: [Partysip-dev] osip

[Aymeric Moizard]

Howard,

I check your diff. thanks for it.
Let me go further:

The file partysip.conf contains a user with login and password set to
'none'. I intend in the future to make it possible for an administrator
to not authenticate a specific user (this is a security hole only open
at the administrator risk...). So when the string 'none' is discovered,
the user entry does not have a login and password set. By now, this
functionnality is not implemented.

In the default configuration, an entry of this kind exist. This is
why you were thinking that an entry for the UA you were registring
was existing... but in fact, this was another entry loaded at launch
time by the proxy itself.

The second point concerns the diff you sent. I modified it this way:

  for (uinfo=user_infos; uinfo!=NULL; uinfo=uinfo->next)
    {
      if (uinfo->login!=NULL&&0==strcmp(login, uinfo->login))
        return uinfo;
    }

This way, the loop will continue to search for a user and won't
stop when the first entry with a login set to NULL is discovered.

The modified file is now included in the CVS and in the temporary
version on osip.atosc.org/pub/download

Aymeric

On Tue, 14 May 2002, Howard Lin wrote:

> Attached is the diff for ppluinfo.c.
>
> Howard
>
> > -----Original Message-----
> > From: Aymeric Moizard [mailto:address@hidden
> > Sent: Tuesday, May 14, 2002 12:12 PM
> > To: Howard Lin
> > Subject: RE: [Partysip-dev] osip
> >
> >
> >
> > On Tue, 14 May 2002, Howard Lin wrote:
> >
> > > I use a Cisco 7960 IP phone. Registration is OK with
> > authentication. But
> > > it crashes when an unknown user trying to register. The code in
> > > ppl_uinfo_find_by_login needs to check if uinfo->login !=
> > NULL (I don't
> > > know why uinfo for the unknown user is created at first
> > place though.)
> >
> > don't know too :->
> > Can you send the modified file to address@hidden
> >
> > > I also tried to make calls between 2 registered IP phones but only
> > > one-way audio is heard.
> >
> > This is probably not a partysip bug? partysip do not modify the SDP
> > packet! Let me know if you find the reason!
> >
> > > But anyway you did a great job for putting up
> > > this simple proxy. Thanks,
> >
> > simple now, but should be powerfull when the statefull mode will
> > come. :)
> >
> > thanks
> > Aymeric
> >
> > > Howard
> > >
> > > > -----Original Message-----
> > > > From: Aymeric Moizard [mailto:address@hidden
> > > > Sent: Tuesday, May 14, 2002 11:55 AM
> > > > To: Howard Lin
> > > > Cc: address@hidden
> > > > Subject: RE: [Partysip-dev] osip
> > > >
> > > >
> > > >
> > > >
> > > > On Tue, 14 May 2002, Howard Lin wrote:
> > > >
> > > > > I use osip0.8.5 and it seems working (compiled,
> > installed, running).
> > > >
> > > > First try, first success? great!
> > > >
> > > > Did you tried authentication? what UA are you running?
> > > > Thanks
> > > > Aymeric
> > > >
> > > >
> > > > > Howard
> > > > > -----Original Message-----
> > > > > From: Matt Porter [mailto:address@hidden
> > > > > Sent: Tuesday, May 14, 2002 11:24 AM
> > > > > To: address@hidden
> > > > > Subject: [Partysip-dev] osip
> > > > >
> > > > >
> > > > > What is the recommended version of osip for use with partysip?
> > > > >
> > > > > Thanks,
> > > > > Matt
> > > > >
> > > >
> > > >
> > >
> >
> >
>