[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Nmh-workers] Starting the final call for features for 1.7
From: |
Ken Hornstein |
Subject: |
Re: [Nmh-workers] Starting the final call for features for 1.7 |
Date: |
Tue, 27 Sep 2016 09:51:29 -0400 |
>The latest code in git is failing to build on Solaris because it
>relies on getline(3). getline was a GNU extension that has now been
>added to recent POSIX specifications but may still be lacking on
>older systems that predate that.
Hm, I thought this was an issue for 1.6, but no ... we branched 1.6 in
April of 2014, and Paul Fox added that code in May of 2014. I did notice
it on MacOS 10.6, but that OS was old at the time so I think it just
fell off everyone's radar.
>Could we perhaps include a configure test and a fallback implementation
>such as the one below (it is a public domain implementation tweaked
>to use mh_xmalloc etc)?
In terms of Autoconf, there is AC_REPLACE_FUNCS designed for this
exact purpose, so the replacment function could be in it's own file.
You'll need to add LIBOJBS to LIBADD as well. Like, I think this in
configure.ac:
AC_CONFIG_LIBOBJ_DIR([sbr])
AC_REPLACE_FUNCS([getline])
Makefile.am:
sbr_libmh_a_LIBADD = $(LIBOBJS)
and put the implementation in sbr/getline.c.
--Ken
- Re: [Nmh-workers] Starting the final call for features for 1.7, (continued)
- Re: [Nmh-workers] Starting the final call for features for 1.7, William Hay, 2016/09/27
- Re: [Nmh-workers] Starting the final call for features for 1.7, Ken Hornstein, 2016/09/27
- Re: [Nmh-workers] Starting the final call for features for 1.7, William Hay, 2016/09/27
- Re: [Nmh-workers] Starting the final call for features for 1.7, Ken Hornstein, 2016/09/27
- Re: [Nmh-workers] Starting the final call for features for 1.7, P Vixie, 2016/09/27
- Re: [Nmh-workers] Starting the final call for features for 1.7, William Hay, 2016/09/28
Re: [Nmh-workers] Starting the final call for features for 1.7, Oliver Kiddle, 2016/09/27