[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [PATCH] extended color support

From: Brand Huntsman
Subject: Re: [Nano-devel] [PATCH] extended color support
Date: Sat, 27 Jan 2018 15:45:58 -0700

On Sat, 27 Jan 2018 13:43:01 +0100
Benno Schulenberg <address@hidden> wrote:

> > The bright prefix and bold attribute do the same thing, they set
> > the A_BOLD attribute. The new variable name is exactly what should
> > happen.  
> That may be the case, but first: the rename is not needed to make the
> code work, and second: the bright variable is not renamed anywhere
> else, which makes it confusing.  If you want to rename things, 1) do
> it everywhere, 2) do it in a separate patch.

Where is the bright variable not renamed?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]