[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [PATCH] extended color support

From: Benno Schulenberg
Subject: Re: [Nano-devel] [PATCH] extended color support
Date: Sat, 27 Jan 2018 13:43:01 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0

Op 27-01-18 om 12:43 schreef Brand Huntsman:
On Sat, 27 Jan 2018 12:07:28 +0100 Benno Schulenberg <address@hidden>
Why?  This is not needed to get extra colors.  Don't add stuff that is not
necessary in order to implement extra colors.  Plus: I hate underline, and I
hate reverse in normal text, and my terminal can't do italic, so all those
extra attributes are useless to me.

The bold attribute was needed and the others are practically free.

The others are not free: they cost a whole block of code.  But even if
they cost only three lines, it should have been a separate patch, and
not included in the set, because it has nothing to do with adding extra

Why rename this?

The old name was too long and prevented the code from fitting in 80 columns.

Don't worry about the 80 columns.  Worry about changing as few lines
as possible.

Another rename!

The bright prefix and bold attribute do the same thing, they set the A_BOLD
attribute. The new variable name is exactly what should happen.

That may be the case, but first: the rename is not needed to make the code
work, and second: the bright variable is not renamed anywhere else, which
makes it confusing.  If you want to rename things, 1) do it everywhere,
2) do it in a separate patch.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]