[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [PATCH] extended color support

From: Benno Schulenberg
Subject: Re: [Nano-devel] [PATCH] extended color support
Date: Sat, 27 Jan 2018 12:07:28 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0

Op 21-01-18 om 09:55 schreef Brand Huntsman:
Adds bold, italic, reverse and underline attributes.

Why?  This is not needed to get extra colors.  Don't add stuff that
is not necessary in order to implement extra colors.  Plus: I hate
underline, and I hate reverse in normal text, and my terminal can't
do italic, so all those extra attributes are useless to me.

A few details from the first patch:

-           const colortype *beforenow = sint->color;
+           const colortype *prev = sint->color;

Why rename this?  It unnecessarily increases the size of the patch,
and makes me having to check whether something is just a rename or
an actual change.  It pisses me off.

Also, keep the style that nano uses: operators are place at the end
of continued lines, not at the beginning.

-       *bright = TRUE;
+       /* The bright foreground prefix makes the color bold and bright,
+        * or only bright on terminals without bold support. */
+       *bold = TRUE;

Another rename!  And a majorly confusing one.  What I expected to see
is that "bright" will now make a color only bright, and "bold" will
make it only bold when the terminal can do bold, but will make it
bright otherwise (if the terminal can do that).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]