[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] tab completion in the browser

From: Rishabh Dave
Subject: Re: [Nano-devel] tab completion in the browser
Date: Sun, 24 Apr 2016 21:19:43 +0530

On Sun, Apr 24, 2016 at 1:16 AM, Benno Schulenberg <address@hidden> wrote:

The patch works.  Nice!  :)

Thanks.  :D

One small improvement would be easy: both assignments to path_for_tab_c
are immediately followed by goto change_browser_directory, so it would be
cheaper and more central to set path_for_tab_c there, a little later, after
the assignment to path.  Which means that you don't have to do the first
assignment of "./" at all (which, by the way, was misplaced: it is among
the declarations).

These changes are brought in tab-completion-improved.patch.

(And in a later patch you can probably melt path_for_tab_c and path_save
into a single global variable.)

This one is in tab-completion-using-path-save.patch.

Attachment: tab-completion-improved.patch
Description: Text Data

Attachment: tab-completion-using-path_save.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]