[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Mingw-cross-env-list] update on pull request

From: Volker Grabsch
Subject: Re: [Mingw-cross-env-list] update on pull request
Date: Fri, 29 May 2015 11:29:06 +0200
User-agent: Mutt/1.5.23 (2014-03-12)

Rashad M schrieb:
> On Thu, May 28, 2015 at 10:40 PM, Volker Grabsch <address@hidden> wrote:
> > I believe the biggest issue with your pull request is that it is too
> > big.  Yes, it is split into multiple commits, and that helps a lot.
> > But as a single pull request this is still an "all or nothing" thing.
> [...]
> Timothy had really helped me fix a lot of issues in the commit and make it
> more easy for other packages. I really appreciate that. As you said, the
> pull request is very big and timothy volunteered to review it. I understand
> its been tiring to him too that is why I approached list. He had cleary
> mentioned that he is busy and cannot guarantee any time now.

I can't speak for Timothy, but for most people it is easier to find multiple
blocks of 10 minutes each, rather than one free time block of an hour or more.

> In the first pull request I was asked to split commits. So I closed it and
> reopned another from a different fork.
> So I dont want to go through those steps again, and want this to merged
> before continuing on other packages.  I apologize if my frequent request
> for asking review has been irritating.
> Now I should close the pull request, open a branch or fork new and create
> multiple pull requests.

Indeed, this should have been made more clear from the very beginning.
Sorry for that.

Instead of telling you to split into multiple commits, we should have
told you to split into multiple pull requests.

Also, we should have told you not to extended the pull request any
further, but to create a new pull request for each new topic.  I just
noticed yesterday how large the pull request has become, that's why
I was speaking up.  I should have noticed earlier.

Note that this principle is not specific to MXE in any way.  It
applies equally to almost every Free Software project.  It also
applies not just to pull requests, but to issue trackers and many
other things.


Volker Grabsch

reply via email to

[Prev in Thread] Current Thread [Next in Thread]