[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Mingw-cross-env-list] update on pull request

From: Rashad M
Subject: Re: [Mingw-cross-env-list] update on pull request
Date: Fri, 29 May 2015 11:02:33 +0200

On Thu, May 28, 2015 at 10:40 PM, Volker Grabsch <address@hidden> wrote:
Hi Rashad,

Sorry for not reviewing your pull request and just providing
"organizational" hints, but:

I believe the biggest issue with your pull request is that it is too
big.  Yes, it is split into multiple commits, and that helps a lot.
But as a single pull request this is still an "all or nothing" thing.
That requires quite a lot of resources on the reviewer's side, as all
commits have to be reviewed at once by a single person before it can
be merged safely.  Timothy volunteered and took that time, which is
really great!  Nevertheless, this makes him the the bottle neck, which
was completely unnecessary and avoidable on your side.

Timothy had really helped me fix a lot of issues in the commit and make it more easy for other packages. I really appreciate that. As you said, the pull request is very big and timothy volunteered to review it. I understand its been tiring to him too that is why I approached list. He had cleary mentioned that he is busy and cannot guarantee any time now.

I strongly advice to split this pull request into multiple pull
requests, which means creating a separate branch for each topic.  Each
of these branches should be based on "master", i.e. the branches and
commits should not be based upon each other.  The only exception is if
they really build upon each other.  But even then, try to avoid
putting too much into a single pull request.

In the first pull request I was asked to split commits. So I closed it and reopned another from a different fork.

So I dont want to go through those steps again, and want this to merged before continuing on other packages.  I apologize if my frequent request for asking review has been irritating.

Now I should close the pull request, open a branch or fork new and create multiple pull requests.

Especially in a project like MXE that consists of lots of independent
parts, it is absolutely normal that almost every pull request consist
of just a single, small commit.

This is exactly blocking me from adding another packages, as it make pull request grow more. 

That way, others can step in to review some parts.  And even for a
single reviewer it is more motivating and satisfying to finish the
reviews step by step, rather than all at once.  If that had been the
case from the very beginning, I bet most of your commits would have
been merged already, leaving only the really controversial ones to be

Again, sorry for just talking and not reviewing anything.  But I think
it is important to talk about the elephant in the room.  It is
unhealthy to build more and more guilty conscience on the reviewers,
when the real problem is not on their side and there's nothing they
can do about it.

There is no reason for reviewer to feel guilty. He is helping from his own time and I understand. Only thing is more and more commits make it difficult on both sides.

Once again, thanks to timothy's effort in reviewing this pull request.

I hope this helps you to understand how this unfortunate situation
emerged, and what you can do to push things forward, apart from
pinging the reviewers.  Note that regularily pinging the reviewers is
still a good thing to do, but there's a lot more you can do to help us
incorporating your improvements more quickly.



Rashad M schrieb:
> Could you or anyone else in the team can help to get this merged. It been
> tiring and kind of blocking for me to add new packages
> On Fri, May 15, 2015 at 10:24 AM, Rashad M <address@hidden>
> wrote:
> > Just Ping!. any update?
> >
> > On Mon, May 4, 2015 at 5:10 PM, Rashad M <address@hidden>
> > wrote:
> >
> >> Any news?
> >>
> >> On Thu, Apr 23, 2015 at 10:37 PM, Rashad M <address@hidden>
> >> wrote:
> >>
> >>> No problem.
> >>>
> >>> I will ping back later. Any guesstimate ? :)
> >>>
> >>> On Thu, Apr 23, 2015 at 6:20 AM, Timothy Gu <address@hidden>
> >>> wrote:
> >>>
> >>>> On Mon, Apr 20, 2015 at 11:14:56PM +0200, Rashad M wrote:
> >>>> > Hello Timothy,
> >>>> >
> >>>> > I had updated pull request. It much better now. Hopefully we can
> >>>> close this
> >>>> > time. Sorry for silence on my part.
> >>>> >
> >>>> > https://github.com/mxe/mxe/pull/534
> >>>> >
> >>>> > Would it be ok to check it and let me know
> >>>>
> >>>> I will as soon as I find time, which I unfortunately cannot promise
> >>>> when.
> >>>> Thank you for following up on this nevertheless.
> >>>>
> >>>> Timothy
> >>>>
> >>>
> >>>
> >>>
> >>> --
> >>> Regards,
> >>>    Rashad
> >>>
> >>
> >>
> >>
> >> --
> >> Regards,
> >>    Rashad
> >>
> >
> >
> >
> > --
> > Regards,
> >    Rashad
> >
> --
> Regards,
>    Rashad

Volker Grabsch


reply via email to

[Prev in Thread] Current Thread [Next in Thread]