[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Mingw-cross-env-list] update on pull request

From: Volker Grabsch
Subject: Re: [Mingw-cross-env-list] update on pull request
Date: Fri, 29 May 2015 18:24:09 +0200
User-agent: Mutt/1.5.23 (2014-03-12)

Rashad M schrieb:
> On Fri, May 29, 2015 at 11:29 AM, Volker Grabsch <address@hidden> wrote:
> >
> > Instead of telling you to split into multiple commits, we should have
> > told you to split into multiple pull requests.
> >
> > Also, we should have told you not to extended the pull request any
> > further, but to create a new pull request for each new topic.  I just
> > noticed yesterday how large the pull request has become, that's why
> > I was speaking up.  I should have noticed earlier.
> >
> > Note that this principle is not specific to MXE in any way.  It
> > applies equally to almost every Free Software project.  It also
> > applies not just to pull requests, but to issue trackers and many
> > other things.
> I totally get your point.
> For future reference, I think it will be worth to note this in guidelines
> for packages. I guess creating packages section[1] will be a good fit.
> [1] http://mxe.cc/#creating-packages

I agree.  Feel free to propose a pull request for index.html, that
would be great!


Volker Grabsch

reply via email to

[Prev in Thread] Current Thread [Next in Thread]