Re: [GMG-Devel] video transcoding creates excessively restricted files

[Christopher Allan Webber]

Kushal Kumaran writes:

> ayleph <address@hidden> writes:
>
>> On 07/02/2013 11:28 AM, ayleph wrote:
>>> On 07/02/2013 11:19 AM, Kushal Kumaran wrote:
>>>> Hi,
>>>>
>>>> I have a mediagoblin setup with nginx/separate-celery following the
>>>> instructions at
>>>> http://docs.mediagoblin.org/siteadmin/production-deployments.html.  When
>>>> I upload a video that needs transcoding, the transcoded file and the
>>>> thumbnail are created with 0600 permissions.  So nginx, which is running
>>>> as a different user, is not able to serve those files.
>>>>
>>>> I tracked down the problem to tempfile.NamedTemporaryFile, which always
>>>> creates files with 0600 permissions, rather than doing 0666 and letting
>>>> the umask adjust the actual permissions.
>>>>
>>>> I have a patch that fixes the problem, but I'm curious to know if other
>>>> people have encountered this problem, and if there are better ways to
>>>> solve it.
>>>
>>> I have most definitely encountered this problem, but I hadn't tracked
>>> down the culprit. Do you have an account on the MediaGoblin Trac site?
>>> It would be the proper place to submit a bug and include your patch, I
>>> think.
>>>
>>> http://issues.mediagoblin.org/
>>
>> I should have checked Trac first myself; it looks like there's already a 
>> related issue from 3 weeks ago about this. No proposed solution though.
>>
>> http://issues.mediagoblin.org/ticket/716
>>
>
> Thanks for the pointer.  I've added a comment and the patch to issue
> 716.

Heya,

Thanks for bringing up this thread.  A lot of people have run into this
problem... you hit the nail on the head of it being the
NamedTemporaryFile.

It turns out we don't even need to be using those, even!  We can get rid
of it...

If someone is willing to take this on, I'd be happy to help them with
it.  Otherwise else I will try to get to it by 0.4.1... but the more
help I can get, the better.