[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Maposmatic-dev] [PATCH 2/4] Implement support for RTL languages in

From: Maxime Petazzoni
Subject: Re: [Maposmatic-dev] [PATCH 2/4] Implement support for RTL languages in street index
Date: Fri, 12 Feb 2010 14:56:14 +0100
User-agent: Mutt/1.5.20 (2009-06-14)

* David MENTRE <address@hidden> [2010-02-12 13:42:38]:

> Hi Maxime,
> 2010/2/12 Maxime Petazzoni <address@hidden>:
> >>  class i18n_template_code_CODE(i18n):
> > Side question: where's this class used? I don't see it anywhere in
> > OCitySMap's code.
> It is never used. It is supposed to be a template of needed methods to
> implement for people wanting to add support for a given language.

In this case, why not make this the default behavior in the i18n class
and remove the useless i18n_template_code_CODE and i18n_generic?

This would also allow you to remove most of the useless overloading in
the children classes.

- Maxime
Maxime Petazzoni <>
 ``One by one, the penguins took away my sanity.''
Linux kernel and software developer at MontaVista Software

Attachment: signature.asc
Description: Digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]