[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Maposmatic-dev] [PATCH 2/4] Implement support for RTL languages in

From: Maxime Petazzoni
Subject: Re: [Maposmatic-dev] [PATCH 2/4] Implement support for RTL languages in street index
Date: Fri, 12 Feb 2010 09:27:18 +0100
User-agent: Mutt/1.5.20 (2009-06-14)


* Thomas Petazzoni <address@hidden> [2010-02-11 23:25:17]:

>  class i18n_template_code_CODE(i18n):
>      def __init__(self, language, locale_path):
>          """Install the _() function for the chosen locale other
> @@ -65,6 +68,9 @@ class i18n_template_code_CODE(i18n):
>             e.g. É and E are equals in French map index"""
>          return a == b
> +    def isrtl(self):
> +        return False
> +

Side question: where's this class used? I don't see it anywhere in
OCitySMap's code. I have other comments to the file, but it's
not relevant here in this review.

The rest LGTM, although again I'd ask for some comments, especially when
you have this kind of funky computations -- some explanations would
help understanding (and troubleshooting if needed) the code.

If you can't write the comments because you don't remember what the code
does, it'll only prove I just made my point :-)

- Maxime
Maxime Petazzoni <>
 ``One by one, the penguins took away my sanity.''
Linux kernel and software developer at MontaVista Software

Attachment: signature.asc
Description: Digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]