Re: GNU make 3.81beta3 released

[Paul D. Smith]

%% "Earnie Boyd" <address@hidden> writes:

  eb> *** work/features/double_colon.base.8   Tue Jun 28 23:34:39 2005
  eb> --- work/features/double_colon.log.8    Tue Jun 28 23:34:39 2005
  eb> ***************
  eb> *** 1,3 ****
  eb>   ok
  eb> ! make: Circular d <- d dependency dropped.
  eb>   oops
  eb> --- 1,3 ----
  eb>   ok
  eb> ! ake: Circular d <- d dependency dropped.
  eb>   oops

  eb> The .log.8 file has a missing m.

Yes, I _JUST_ realized this myself.  I tried using diff -w and got the
same results.

Very curious.  This is a bug in make; it's getting the command name
wrong somehow, for the MINGW port... yeah, this code is wrong:

  #ifdef WINDOWS32
        if (program == 0)
          {
            /* Extract program from full path */
            int argv0_len;
            char *p = strrchr (argv[0], '\\');
            if (!p)
              p = argv[0];
            argv0_len = strlen(p);
            if (argv0_len > 4
                && streq (&p[argv0_len - 4], ".exe"))
              {
                /* Remove .exe extension */
                p[argv0_len - 4] = '\0';
                /* Increment past the initial '\' */
                program = p + 1;
              }
          }
  #endif

Let me look at this a minute.


My concern with using diff -w is that in some tests we do care about
whitespace differences.

-- 
-------------------------------------------------------------------------------
 Paul D. Smith <address@hidden>          Find some GNU make tips at:
 http://www.gnu.org                      http://make.paulandlesley.org
 "Please remain calm...I may be mad, but I am a professional." --Mad Scientist