[lwip-devel] [patch #6699] Fixing a couple of compilation warnings(Paradigm C++)

[Mike Kleshov]

Follow-up Comment #13, patch #6699 (project lwip):

> The int can't be 0xFFFF.
Now I see it... Still, I think the wording of this warning is a bit vague...

> Sure, it's always false, but it's also bad coding style
I suppose adding an explicit check for size of int would be more readable
than relying on the if statement to reduce to 'always false' on 16-bit
platforms. Something like this should work:
#include <limits.h>
#if UINT_MAX > 0xffffu
...
#endif

> That will break the code on many 8- and 16-bit compilers that are not C99
compatible
It won't if you define roll-your-own types like it's currently done with
u8_t, u16_t and so on.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?6699>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/