[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [patch #6699] Fixing a couple of compilation warnings(Parad
From: |
Mike Kleshov |
Subject: |
[lwip-devel] [patch #6699] Fixing a couple of compilation warnings(Paradigm C++) |
Date: |
Sat, 20 Dec 2008 11:27:29 +0000 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.0.4) Gecko/2008102920 Firefox/3.0.4 |
Follow-up Comment #6, patch #6699 (project lwip):
On closer look, it seems that the original behavior (always false) is
desireable:
if ((conn->write_msg->msg.w.len - conn->write_offset > 0xffff)) { /*
max_u16_t */
len = 0xffff;
Apparently, the intent of the code is to limit the 'len' argument (which is
u16_t) passed to tcp_write(). When sizeof(int)==2, the amount of data is
already limited by the integer data type. So 'always false' seems appropriate
here. The easy solution is to revert the patch, then.
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/patch/?6699>
_______________________________________________
Message sent via/by Savannah
http://savannah.nongnu.org/
- [lwip-devel] [patch #6699] Fixing a couple of compilation warnings(Paradigm C++), Tai-hwa Liang, 2008/12/19
- [lwip-devel] [patch #6699] Fixing a couple of compilation warnings(Paradigm C++), Mike Kleshov, 2008/12/19
- [lwip-devel] [patch #6699] Fixing a couple of compilation warnings(Paradigm C++), Simon Goldschmidt, 2008/12/19
- [lwip-devel] [patch #6699] Fixing a couple of compilation warnings(Paradigm C++), Jonathan Larmour, 2008/12/19
- [lwip-devel] [patch #6699] Fixing a couple of compilation warnings(Paradigm C++), Simon Goldschmidt, 2008/12/20
- [lwip-devel] [patch #6699] Fixing a couple of compilation warnings(Paradigm C++),
Mike Kleshov <=
- [lwip-devel] [patch #6699] Fixing a couple of compilation warnings(Paradigm C++), Simon Goldschmidt, 2008/12/20
- [lwip-devel] [patch #6699] Fixing a couple of compilation warnings(Paradigm C++), Bill Auerbach, 2008/12/22
- [lwip-devel] [patch #6699] Fixing a couple of compilation warnings(Paradigm C++), Mike Kleshov, 2008/12/22
- [lwip-devel] [patch #6699] Fixing a couple of compilation warnings(Paradigm C++), Bill Auerbach, 2008/12/22
- [lwip-devel] [patch #6699] Fixing a couple of compilation warnings(Paradigm C++), Mike Kleshov, 2008/12/22
- [lwip-devel] [patch #6699] Fixing a couple of compilation warnings(Paradigm C++), Bill Auerbach, 2008/12/22
- [lwip-devel] [patch #6699] Fixing a couple of compilation warnings(Paradigm C++), Mike Kleshov, 2008/12/22