[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [lwip-devel] [patch #6459] Minor changes to err.h, stats.c & httpd/f

From: Pettinato, Jim
Subject: RE: [lwip-devel] [patch #6459] Minor changes to err.h, stats.c & httpd/fs
Date: Thu, 27 Mar 2008 14:51:44 -0400

I exported stats_display to my telnet module to be able to read the stats over 
the network, so making them static would break that. I vote to continue to 
conditionally include the functions and keep them exportable - for at least the 
top-level stats_display() function (and maintain the function prototypes with 
the same conditional include in stats.h).

-----Original Message-----
From: address@hidden [mailto:address@hidden On Behalf Of Simon Goldschmidt
Sent: Thursday, March 27, 2008 2:44 PM
To: Simon Goldschmidt; Frédéric Bernon; Bill Auerbach; Jonathan Larmour; 
Subject: [lwip-devel] [patch #6459] Minor changes to err.h,stats.c & httpd/fs

Follow-up Comment #3, patch #6459 (project lwip):

httpd: checked in const filenames and u32_t file sizes (that's a real bug: no 
check was done anywhere while converting the original file size from int to

err_t: I think it's a good idea: This has always been a size tradeoff which 
makes lwIP slow on 32-bit processors. But I don't know which is the best thing 
to do. Using enums is not that cool in my opinion: On some systems, you might 
want to force it to 8bit... (Seeing error-names in the debugger would be nice,

I'd make it overridable for a start, but I think that's a thing to discuss...

stats.h/.c: I'd vote for making the functions static. Frédéric, which function 
do you use externally? And how do you do it right now?


Reply to this item at:


  Nachricht geschickt von/durch Savannah

lwip-devel mailing list

reply via email to

[Prev in Thread] Current Thread [Next in Thread]