lwip-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [patch #6459] Minor changes to err.h, stats.c & httpd/fs


From: Simon Goldschmidt
Subject: [lwip-devel] [patch #6459] Minor changes to err.h, stats.c & httpd/fs
Date: Thu, 27 Mar 2008 18:43:40 +0000
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.13) Gecko/20080311 Firefox/2.0.0.13

Follow-up Comment #3, patch #6459 (project lwip):

httpd: checked in const filenames and u32_t file sizes (that's a real bug: no
check was done anywhere while converting the original file size from int to
u16_t...)

err_t: I think it's a good idea: This has always been a size tradeoff which
makes lwIP slow on 32-bit processors. But I don't know which is the best thing
to do. Using enums is not that cool in my opinion: On some systems, you might
want to force it to 8bit... (Seeing error-names in the debugger would be nice,
though.)

I'd make it overridable for a start, but I think that's a thing to
discuss...

stats.h/.c: I'd vote for making the functions static. Frédéric, which
function do you use externally? And how do you do it right now?

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?6459>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]