[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [patch #6370] Sending to myself

From: Luca Ceresoli
Subject: [lwip-devel] [patch #6370] Sending to myself
Date: Fri, 11 Jan 2008 18:21:04 +0000
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; it; rv: Gecko/20071127 Firefox/

Follow-up Comment #4, patch #6370 (project lwip):

> Is having the source IP address set to even a big issue?
Not necessarily, but the first patch led to dropped packets at the UDP level
when the pcb is bound to a local address, and maybe other problems also
involving TCP. Going on with that patch would have led to patching udp.c and
perhaps tcp.c and icmp.c. Sounds bad for IP-related things. _This_ was the
meaning of "invasive", not the quantity of code.
Apart for this, ain't it conceptually wrong to send through the loopif a
packet directed to, say,

My next try is basically the same as the previous, plus the removal of most
code from loopif. The loopif has now its behaviour for free, being a netif.
Apart from coding style and where-to-place-it, this is substantially what was
suggested so far (comments #1, #2 and #3): one piece of code to be used for
both loopif and IP_TO_SELF.

The only real difference is that the IP_TO_SELF feature is available without
creating a loopif.
More logical implementation and user interface, that's it.

In this new patch there's still some pre-processor dirt to maintain
compatibility with the current loopif interface: loopif_poll(), the
compile-time options and most notably the multithreading defines.
If it's worth breaking compatibility to clean this code, I can't say.

(file #14784)

Additional Item Attachment:

File name: self-netif2.patch              Size:14 KB


Reply to this item at:


  Messaggio inviato con/da Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]