[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [patch #6370] Sending to myself

From: Jonathan Larmour
Subject: [lwip-devel] [patch #6370] Sending to myself
Date: Fri, 11 Jan 2008 15:02:09 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20070530 Fedora/ Firefox/

Follow-up Comment #2, patch #6370 (project lwip):

After taking the approach of changing ip_route() there were some issues, but
you said these would be too invasive to fix. But I wouldn't have thought it
would be that invasive; or at least less so than the patch here. It seems not
very good to have so much new code here, especially since it's similar to

Is having the source IP address set to even a big issue?

Or even if ip_route() doesn't work so well I would have thought something
like this in ip_output_if() would do (similar to what you were already
proposing changing:

  if (ip_addr_cmp(dest, &netif->ip_addr)) {

    /* Packet to self, enqueue it */

    LWIP_DEBUGF(IP_DEBUG, ("Passing to loopif"));

    return loopif_output(netif, p, dest);

  } else

#endif /* LWIP_HAVE_LOOPIF */

    LWIP_DEBUGF(IP_DEBUG, ("netif->output()"));

    return netif->output(netif, p, dest);


And make loopif_output no longer be static.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]