[lwip-devel] [task #7017] Implement DNS client

[David Empson]

Follow-up Comment #85, task #7017 (project lwip):

Just a comment regarding the proposed LWIP_MAKE_ADDRWORD macro or equivalent
expression: it would be handy if this was written in a way which allows it to
be used on a compiler for a 16-bit processor without having to modify core
LWIP source code.

If sizeof(int) == 2 then the << 16 and << 24 operations will produce a zero
result. It is necessary to force a 32-bit shift operation, e.g. by typecasting
the first and second elements to a 32-bit unsigned integer type before doing
the shift.

This may be an issue that should be left for people doing their own ports,
but the C standard only requires sizeof(int) to be at least 16 bits, and I'd
argue that LWIP should be written to be compliant with standard C rather than
assuming the now more common environment with 32-bit integers.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/task/?7017>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/