[lwip-devel] [task #6933] Review usage of ASSERT and error handling with LWIP_NOASSERT

[Frédéric Bernon]

Follow-up Comment #9, task #6933 (project lwip):

>Because of that, I wouldn't call it LWIP_FATAL. Giving a wrong argument
isn't fatal. 

What is "fatal" is to continue with a such argument.

>Still I'm OK with changing the if(..) return ..; to something else. I don't
think that including 'return ERR_ARG;' in LWIP_FATAL() is a good solution,
though. It might be better to call id LWIP_CHECK_ARG() and give 'return X;'
as another argument to that define...

Sorry, I don't really see (except the name) what is the difference between
this...

LWIP_FATAL("netconn_close: invalid conn", (conn==NULL), {return ERR_ARG;}); 

...and this...

LWIP_CHECK_ARG(conn != NULL, return ERR_ARG);

Except the message with is important to give an information, and the "!=" (it
avoid to add the "!" in the evaluation).

Last about the name, LWIP_CHECK_ARG is not so good (you could do that on an
expression, not only an argument). I propose you to use LWIP_ERROR (which is
currently not used, so, we can change it)...


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/task/?6933>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.nongnu.org/