[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [task #6933] Review usage of ASSERT and error handling with

From: Simon Goldschmidt
Subject: [lwip-devel] [task #6933] Review usage of ASSERT and error handling with LWIP_NOASSERT
Date: Wed, 13 Jun 2007 10:46:21 +0000
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv: Gecko/20070515 Firefox/

Follow-up Comment #8, task #6933 (project lwip):

While I can understand Frédéric's need for a faster stack (and leaving away
'double' checks), I still think it is necessary to have some argument checks.
Because of that, I wouldn't call it LWIP_FATAL. Giving a wrong argument
_isn't_ fatal.

Still I'm OK with changing the if(..) return ..; to something else. I don't
think that including 'return ERR_ARG;' in LWIP_FATAL() is a good solution,
though. It might be better to call id LWIP_CHECK_ARG() and give 'return X;'
as another argument to that define...

e.g. LWIP_CHECK_ARG(conn != NULL, return ERR_ARG);


Reply to this item at:


  Nachricht geschickt von/durch Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]