lwip-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [patch #5914] Move sockopt processing into tcpip_thread


From: Frédéric Bernon
Subject: [lwip-devel] [patch #5914] Move sockopt processing into tcpip_thread
Date: Fri, 04 May 2007 16:54:06 +0000
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3

Follow-up Comment #14, patch #5914 (project lwip):

I will look the igmp part, but not before Wednesday (weekend, vacation,
holidays, yes!!! Is it possible to you to wait before commit that?).

But, you don't answer to comment# 11 first part.

Are you agree with the fact that netconn & sockets, if one day we split them,
will share most of the code of api_msg? So, if some part of api_msg has to be
different for socket and for netconn, we will need something to tell if the
user need such or such part ?

So, LWIP_SOCKETS could be used to tell in api_lib/api_msg if you have to
include specific api_msg extension. And a LWIP_NETCONN should also be used do
enable netconn specific functions.

In api_msg.c, we should get something like :

/*pseudo code*/
#if LWIP_SOCKETS
do_getsockopt()
{ ...
}

do_setsockopt()
{ ...
}
#endif 

#if LWIP_NETCONN
do_netconn_nodelay( int enable) // by example
{ if ( enable) {
    msg->conn->pcb.tcp->flags |= TF_NODELAY;
  } else {
    msg->conn->pcb.tcp->flags &= ~TF_NODELAY;
  }
}
#endif



    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?5914>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.nongnu.org/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]