Re: [lmi] May 2018 wx upgrade (was: Saving and restoring window geometry)

[Vadim Zeitlin]

On Mon, 30 Apr 2018 15:11:26 +0000 Greg Chicares <address@hidden> wrote:

GC> Thanks. Our [2018-05-01, 2018-05-31] release has just been announced.
GC> It would be ideal to upgrade wx for the [2018-06-01, 2018-06-30]
GC> release, where no significant user-visible change in lmi code is
GC> planned: that way, we can spend plenty of time testing the wx upgrade
GC> in advance, and if it unexpectedly causes any problems for end users,
GC> we can revert it without losing any big new feature they care about.

 I see, thanks. Just to check that I am not forgetting anything: were there
any other wxWidgets enhancements potentially useful for lmi? So far this
upgrade will have 2 of those: liblzma support and the changes discussed
here, am I forgetting anything else?

 Looking at my lmi TODO, I only see various Wine bugs (black and white
icons, corrupted wxSpinCtrl etc) and, also, in a rather chronologically
remote part of it, mention of "textlength" XRC attribute that was supposed
to be added to allow specifying text controls/comboboxes/other similar
controls withs in terms of their contents, rather than dialog units. Would
anything of this (or, again, of the possibly but not certainly empty set of
things I'm forgetting) be useful enough to try to include it in this
upgrade?


GC> > I didn't have time to test this under Wine yet,
GC> > however, so I plan to do it next and, if there are no problems found 
there,
GC> > and also if there are no other comments about this PR, I'm going to merge
GC> > it soon.
GC> 
GC> Please don't treat any 'wine' anomaly as a blocking issue solely on
GC> my account. All my 'wine' windows are always maximized, and I never
GC> change their size (except when testing changes like this), so my
GC> interest in whether this works with 'wine' is only academic.

 It's lucky that you wrote this because Wine does seem to have a bug here
and restoring the maximized window still doesn't restore its position
correctly, even with the latest changes. I think it's a Wine bug and
reported it at https://bugs.winehq.org/show_bug.cgi?id=45099 and it's not
impossible that it will be fixed in the future Wine versions (I'm rather
impressed with the speed with which my previous bug reports were
addressed), but this is still not going to work for you right now, with the
version of Wine currently in Buster (even the -development one).

 Regards,
VZ