[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Linphone-developers] bzrtp support for AES with 256-bit keys

From: Ben Sartor
Subject: Re: [Linphone-developers] bzrtp support for AES with 256-bit keys
Date: Fri, 23 Jan 2015 03:58:28 +0100
User-agent: KMail/4.14.1 (Linux/3.16.0-4-amd64; KDE/4.14.2; x86_64; ; )

Hi Johan,

thanks for you answer. I have tried to implement things like you suggested.

Patches 0001 and 0002 are unchanged.

Patches 0003 to 0005 add the the getter and setter you suggested.

Patches 0006 to 0009 implement the tests. I completely refactored the function 
"test_algoAgreement". Is it ok for you to write tests this way?

Patches 0010 to 0012 are some code cleanup suggestions and were not discussed 
before. Let me know what you think. 
Is there a better place for the min-function? Maybe even a macro like 
discussed here [1]? Is "__typeof__" ok?


The mediastreamer2 patch of my initial post still applies and may be used for 

Kind Regards,

> Hi Ben,
> > Yes. Just to be sure, did you mean implementing functions like this:
> > 
> > void bzrtp_setSupportedCipherTypes(bzrtpContext_t *zrtpContext, uint8_t
> > availableTypes[7], const uint8_t availableTypesCount);
> > 
> > uint8_t bzrtp_getSupportedCipherTypes(bzrtpContext_t *zrtpContext, uint8_t
> > availableTypes[7]);
> Yes but you want to add an uint8_t algoType argument(just like
> bzrtpCrypto_getAvailableCryptoTypes function) to both of them in order
> to use the same function to get/set the available algos for block
> cipher/key exchange/SAS rendering/Hash.
> >> This means we also must add a way to store the user configuration in
> >> linphone. I was thinking the easiest way would be to store it in the
> >> config file and access it only manually for now. I can implement this if
> >> you're lost on the way linphone manage the config file.
> > 
> > I haven't had a look to  linphone config file management, yet. Let's see
> > how far I get or if you find time first.
> It's quite simple, but if you struggle tell me and I'll have a look at
> it when you're done with bzrtp. We can use an already existing config
> setting used to select SRTP protection profile(see misc.c const
> MSCryptoSuite * linphone_core_get_srtp_crypto_suites(LinphoneCore *lc);)
> for the block cipher algo selection and do something for the other algo
> types when needed.
> >> Last, this must be covered by automatic tests.(Key exchange between two
> >> users using different set of cipher block algo)
> > 
> > I'm not sure what you mean: Would you prefer a test similar to the
> > existing
> > "test_algoAgreement" or would it be better to write a test for the
> > function
> > "selectCommonAlgo" directly?
> I was thinking of extending the test_algoAgreement to include block
> cipher selection and some test on linphone call to check correct reading
> of the configuration from file, but it can't harm to have a test for the
> selectCommonAlgo too.
> Thanks for your contribution.
> Have a good day
> johan
> _______________________________________________
> Linphone-developers mailing list
> address@hidden

free and secure calls

fon: +49-(0)221-999 999 30
fax: +49-(0)221-999 999 31                                   
mail: address@hidden


Attachment: 0001-fixed-cipher-algorothm-type-parsing-of-AES3.patch
Description: Text Data

Attachment: 0002-added-cipher-algorithm-AES-with-256-bit-keys-AES3.patch
Description: Text Data

Attachment: 0003-selectCommonAlgo-now-is-a-global-function.patch
Description: Text Data

Attachment: 0006-reactivated-tests-suites-of-Crypto-Wrappers-and-Cryp.patch
Description: Text Data

Attachment: 0004-zrtp-crypto-types-are-public-now.patch
Description: Text Data

Attachment: 0005-added-getter-and-setter-for-supported-crypto-types.patch
Description: Text Data

Attachment: 0007-test-now-checks-for-AES3-as-default-value.patch
Description: Text Data

Attachment: 0008-test-algoAgreement-now-checks-more-cases-for-key-agr.patch
Description: Text Data

Attachment: 0009-new-test-for-getter-setter-of-supported-crypto-types.patch
Description: Text Data

Attachment: 0010-packet-parser-now-checks-maxium-of-7-algorithm-types.patch
Description: Text Data

Attachment: 0011-selectCommonAlgo-now-makes-sure-to-not-return-an-arr.patch
Description: Text Data

Attachment: 0012-selectCommonAlgo-now-prevents-adding-the-same-elemen.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]