[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Linphone-developers] bzrtp support for AES with 256-bit keys

From: Peter Villeneuve
Subject: Re: [Linphone-developers] bzrtp support for AES with 256-bit keys
Date: Mon, 19 Jan 2015 20:52:13 +0000

Great thanks.

Looking forward to seeing this ZRTP patch applied.

I noticed that in that repo there is no issue tracker. How do we signal issues to Belledone like the Note 2/3 black screen I've reported on the list before?



On Mon, Jan 19, 2015 at 9:22 AM, Ghislain MARY <address@hidden> wrote:

You can browse the bzrtp code at


Le 18/01/2015 18:47, Peter Villeneuve a écrit :
Hi guys,

Has this patch been applied yet? I'd like to test it out.
By the way, where can we see the latest commits and changelog without having to download the code?

The openhub site is good but is always many days behind.

On Thu, Jan 15, 2015 at 2:15 PM, Johan Pascal <address@hidden> wrote:
Hi Ben,

Yes. Just to be sure, did you mean implementing functions like this:

void bzrtp_setSupportedCipherTypes(bzrtpContext_t *zrtpContext, uint8_t
availableTypes[7], const uint8_t availableTypesCount);

uint8_t bzrtp_getSupportedCipherTypes(bzrtpContext_t *zrtpContext, uint8_t

Yes but you want to add an uint8_t algoType argument(just like bzrtpCrypto_getAvailableCryptoTypes function) to both of them in order to use the same function to get/set the available algos for block cipher/key exchange/SAS rendering/Hash.

This means we also must add a way to store the user configuration in
linphone. I was thinking the easiest way would be to store it in the
config file and access it only manually for now. I can implement this if
you're lost on the way linphone manage the config file.

I haven't had a look to  linphone config file management, yet. Let's see how far
I get or if you find time first.
It's quite simple, but if you struggle tell me and I'll have a look at it when you're done with bzrtp. We can use an already existing config setting used to select SRTP protection profile(see misc.c const MSCryptoSuite * linphone_core_get_srtp_crypto_suites(LinphoneCore *lc);) for the block cipher algo selection and do something for the other algo types when needed.

Last, this must be covered by automatic tests.(Key exchange between two
users using different set of cipher block algo)

I'm not sure what you mean: Would you prefer a test similar to the existing
"test_algoAgreement" or would it be better to write a test for the function
"selectCommonAlgo" directly?
I was thinking of extending the test_algoAgreement to include block cipher selection and some test on linphone call to check correct reading of the configuration from file, but it can't harm to have a test for the selectCommonAlgo too.

Thanks for your contribution.

Have a good day


Linphone-developers mailing list

Linphone-developers mailing list

Linphone-developers mailing list

reply via email to

[Prev in Thread] Current Thread [Next in Thread]