[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issu
From: |
jonas . hahnfeld |
Subject: |
Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by address@hidden) |
Date: |
Tue, 17 Mar 2020 13:40:43 -0700 |
https://codereview.appspot.com/553700043/diff/547770043/mf/GNUmakefile
File mf/GNUmakefile (right):
https://codereview.appspot.com/553700043/diff/547770043/mf/GNUmakefile#newcode40
mf/GNUmakefile:40: $(UPDATE_TARGET)
I see spurious rebuilds if I re-run make and I think this is because the
touch in UPDATE_TARGET is apparently only executed once.
https://codereview.appspot.com/553700043/diff/547770043/mf/GNUmakefile#newcode67
mf/GNUmakefile:67: EXTRA_DIST_FILES += README mf2pt1.mp invoke-mf2pt.sh
r
'r'?
https://codereview.appspot.com/553700043/diff/547770043/mf/invoke-mf2pt1.sh
File mf/invoke-mf2pt1.sh (right):
https://codereview.appspot.com/553700043/diff/547770043/mf/invoke-mf2pt1.sh#newcode32
mf/invoke-mf2pt1.sh:32: --name=$name $src
Still mixes tabs and spaces
https://codereview.appspot.com/553700043/diff/547770043/mf/invoke-mf2pt1.sh#newcode34
mf/invoke-mf2pt1.sh:34: echo -n "$target : " > ${name}.dep
This doesn't work for me because $target is an absolute path. On top of
an older version I had the following:
diff --git a/mf/invoke-mf2pt.sh b/mf/invoke-mf2pt.sh
index ea2afe771f..aa5740240a 100755
--- a/mf/invoke-mf2pt.sh
+++ b/mf/invoke-mf2pt.sh
@@ -8,7 +8,8 @@ realpath() {
set -eu
mf2pt1=$(realpath $1)
src=$(realpath $2)
-target=$(realpath $3)
+target=$3
+target_path=$(realpath $target)
srcdir=$(dirname ${src})
name=$(basename ${src} .mf)
@@ -16,7 +17,7 @@ name=$(basename ${src} .mf)
#
# the soft link for mf2pt1.mp is for recent mpost versions
# which no longer dump a .mem file
-tmp=$(dirname $target)/tmp.$(basename $target)
+tmp=$(dirname $target_path)/tmp.$(basename $target)
rm -rf $tmp
mkdir $tmp
cd $tmp
https://codereview.appspot.com/553700043/
- Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by address@hidden), (continued)
- Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by address@hidden), hanwenn, 2020/03/16
- Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by address@hidden), lemzwerg, 2020/03/17
- Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by address@hidden), jonas . hahnfeld, 2020/03/17
- Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by address@hidden), dak, 2020/03/17
- Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by address@hidden), jonas . hahnfeld, 2020/03/17
- Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by address@hidden), jonas . hahnfeld, 2020/03/17
- Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by address@hidden), hanwenn, 2020/03/17
- Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by address@hidden), jonas . hahnfeld, 2020/03/17
- Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by address@hidden), jonas . hahnfeld, 2020/03/17
- Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by address@hidden), hanwenn, 2020/03/17
- Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by address@hidden),
jonas . hahnfeld <=
- Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by address@hidden), jonas . hahnfeld, 2020/03/17
- Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by address@hidden), hanwenn, 2020/03/17
- Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by address@hidden), jonas . hahnfeld, 2020/03/17
- Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by address@hidden), jonas . hahnfeld, 2020/03/18
- Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by address@hidden), jonas . hahnfeld, 2020/03/19
- Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by address@hidden), jonas . hahnfeld, 2020/03/20
- Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by address@hidden), hanwenn, 2020/03/21