Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by address@hidden)

[jonas . hahnfeld]

https://codereview.appspot.com/553700043/diff/567370043/mf/GNUmakefile
File mf/GNUmakefile (right):

https://codereview.appspot.com/553700043/diff/567370043/mf/GNUmakefile#newcode36
mf/GNUmakefile:36: $(src-dir)/invoke-mf2pt.sh $(buildscript-dir)/mf2pt1
$< $@ $(METAFONT_QUIET)
Should this script be called invoke-mf2pt1.sh? The package is also
called mf2pt1

https://codereview.appspot.com/553700043/diff/567370043/mf/GNUmakefile#newcode39
mf/GNUmakefile:39: $(UPDATE_TARGET)
Can we list .tfm and .log files directly as output of above rule that
produces .pfb? As far as I understand, mf2pt1 produces all three of
them, right?

https://codereview.appspot.com/553700043/diff/567370043/mf/invoke-mf2pt.sh
File mf/invoke-mf2pt.sh (right):

https://codereview.appspot.com/553700043/diff/567370043/mf/invoke-mf2pt.sh#newcode4
mf/invoke-mf2pt.sh:4: realpath() {
AFAIK sh syntax would be
realpath()
(
  ...
)

Curly braces are not part of POSIX

https://codereview.appspot.com/553700043/diff/567370043/mf/scan-mf-deps.py
File mf/scan-mf-deps.py (right):

https://codereview.appspot.com/553700043/diff/567370043/mf/scan-mf-deps.py#newcode1
mf/scan-mf-deps.py:1: #!/usr/bin/python
This should be #!@PYTHON@ so that setting PYTHON in configure is taken
into account.

https://codereview.appspot.com/553700043/diff/567370043/mf/scan-mf-deps.py#newcode10
mf/scan-mf-deps.py:10: re.sub("\\(%s/?([^\n )]*\\.mf)" % srcdir, lambda
m: deps.append(m.group(1)), input)
Now that should be very possible with sed in .sh plus you already have
all the information available and don't need to parse it from sys.argv

https://codereview.appspot.com/553700043/