Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by address@hidden)

[hanwenn]

https://codereview.appspot.com/553700043/diff/545720043/mf/GNUmakefile
File mf/GNUmakefile (right):

https://codereview.appspot.com/553700043/diff/545720043/mf/GNUmakefile#newcode36
mf/GNUmakefile:36: $(call ly_progress,Making,$@,< mf)
On 2020/03/19 08:29:59, hahnjo wrote:
> Should be $(outdir)/%.pfb instead of $@

Done.

https://codereview.appspot.com/553700043/diff/545720043/mf/GNUmakefile#newcode63
mf/GNUmakefile:63: EXTRA_DIST_FILES += README mf2pt1.mp invoke-mf2pt.sh
r
On 2020/03/19 08:29:59, hahnjo wrote:
> Extraneous 'r' at the end

Done.

https://codereview.appspot.com/553700043/diff/545720043/mf/GNUmakefile#newcode124
mf/GNUmakefile:124: $(call ly_progress,Making,$@,< log)
On 2020/03/19 08:29:59, hahnjo wrote:
> Should (probably) be $(outdir)/%.lisp instead of $@

Done.

https://codereview.appspot.com/553700043/diff/545720043/mf/GNUmakefile#newcode141
mf/GNUmakefile:141: $(call ly_progress,Making,$@,)
On 2020/03/19 08:29:59, hahnjo wrote:
> $(outdir)/emmentaler-$*.otf

Done.

https://codereview.appspot.com/553700043/diff/545720043/mf/GNUmakefile#newcode149
mf/GNUmakefile:149: $(call ly_progress,Making,$@,)
On 2020/03/19 08:29:59, hahnjo wrote:
> $(outdir)/emmentaler-brace.otf

Done.

https://codereview.appspot.com/553700043/diff/545720043/mf/invoke-mf2pt1.sh
File mf/invoke-mf2pt1.sh (right):

https://codereview.appspot.com/553700043/diff/545720043/mf/invoke-mf2pt1.sh#newcode24
mf/invoke-mf2pt1.sh:24: ln -s ../../mf2pt1.mp .
On 2020/03/19 08:29:59, hahnjo wrote:
> This link is not correct for out-of-tree builds. However MetaPost
still finds
> mf2pt1.mp correctly in $srcdir because MFINPUTS is set below. I think
all of
> this linking can be removed.

Done.

https://codereview.appspot.com/553700043/diff/545720043/mf/invoke-mf2pt1.sh#newcode34
mf/invoke-mf2pt1.sh:34: echo -n "$target : " > ${name}.dep
On 2020/03/19 08:29:59, hahnjo wrote:
> As I said before this doesn't work because $target is an absolute
path. My
> suggestion is to assign target=$3 and introduce target_path=$(realpath
$target)

Done.

https://codereview.appspot.com/553700043/diff/545720043/mf/invoke-mf2pt1.sh#newcode38
mf/invoke-mf2pt1.sh:38: touch *.pfb *.tfm *.log *.dep
On 2020/03/19 08:29:59, hahnjo wrote:
> Should not be needed anymore

Done.

https://codereview.appspot.com/553700043/