[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Address output-distance problems: (issue 563730043 by address@hidden
From: |
jonas . hahnfeld |
Subject: |
Re: Address output-distance problems: (issue 563730043 by address@hidden) |
Date: |
Thu, 12 Mar 2020 05:38:00 -0700 |
On 2020/03/12 10:10:23, hahnjo wrote:
> On 2020/03/12 10:03:22, dak wrote:
> > Patch needs work (whether it contains a problem itself or triggers a
> > preexisting one that needs to be fixed in order for the patch to go
ahead),
> but
> > it was caught before the problem affected everyone.
>
> I think it already affects everyone: Current master fails 'make check'
if you're
> building out-of-tree. That's a stopper for testing new patches. So we
have to
> decide now to either a) give this updated patch a try with patchy or
b) just
> disable the test by removing 'local-check' in
scripts/build/GNUmakefile. If it's
> still broken when I come home, I'll do b).
Pushed to staging:
commit 92b75c19c78b426d453c1e8ec7cda39a0d552fb3
Author: Jonas Hahnfeld <address@hidden>
Date: Thu Mar 12 13:35:28 2020 +0100
Deactivate self-tests of output-distance.py
This doesn't work for out-of-tree builds because the script is not
copied over. Furthermore the test is broken on Ubuntu with dash due
to bash-isms in the system() commands.
diff --git a/scripts/build/GNUmakefile b/scripts/build/GNUmakefile
index d406b38b59..8cdd6c22d7 100644
--- a/scripts/build/GNUmakefile
+++ b/scripts/build/GNUmakefile
@@ -14,6 +14,3 @@ include $(depth)/make/stepmake.make
#INSTALLATION_OUT_FILES1=$(outdir)/lilypond-login
$(outdir)/lilypond-profile
all: $(INSTALLATION_FILES)
-
-local-check:
- $(PYTHON) output-distance.py --test
https://codereview.appspot.com/563730043/
- Re: Address output-distance problems: (issue 563730043 by address@hidden), (continued)
- Re: Address output-distance problems: (issue 563730043 by address@hidden), Han-Wen Nienhuys, 2020/03/13
- Re: Address output-distance problems: (issue 563730043 by address@hidden), Dan Eble, 2020/03/12
- Re: Address output-distance problems: (issue 563730043 by address@hidden), Kevin Barry, 2020/03/13
- Re: Address output-distance problems: (issue 563730043 by address@hidden), David Kastrup, 2020/03/13
- Re: Address output-distance problems: (issue 563730043 by address@hidden), Dan Eble, 2020/03/13
- Re: Address output-distance problems: (issue 563730043 by address@hidden), Jonas Hahnfeld, 2020/03/12
Re: Address output-distance problems: (issue 563730043 by address@hidden), jonas . hahnfeld, 2020/03/12
Re: Address output-distance problems: (issue 563730043 by address@hidden), jonas . hahnfeld, 2020/03/12
Re: Address output-distance problems: (issue 563730043 by address@hidden), dak, 2020/03/12
Re: Address output-distance problems: (issue 563730043 by address@hidden), jonas . hahnfeld, 2020/03/12
Re: Address output-distance problems: (issue 563730043 by address@hidden),
jonas . hahnfeld <=
Re: Address output-distance problems: (issue 563730043 by address@hidden), hanwenn, 2020/03/21