Re: Cleanup initialization of configure process (issue 549350043 by address@hidden)

[jonas . hahnfeld]

On 2020/01/08 18:09:53, hahnjo wrote:
> On 2020/01/08 18:03:36, dak wrote:
> > On 2020/01/08 17:48:36, hahnjo wrote:
> > > On 2020/01/08 16:43:24, dak wrote:
> > > > mailto:address@hidden writes:
> > > >
> > > > > Reviewers: dak,
> > > > >
> > > > > Message:
> > > > > On 2020/01/08 16:18:25, dak wrote:
> > > > >>
https://codereview.appspot.com/549350043/diff/581410043/configure.ac
> > > > >> File configure.ac (right):
> > > > >
> > > > >
> > > > >
> > >

https://codereview.appspot.com/549350043/diff/581410043/configure.ac#newcode7
> > > > >> configure.ac:7: AC_INIT([LilyPond], [2.21.0],
> > > mailto:[address@hidden],
> > > > >> [lilypond], [http://lilypond.org/])
> > > > >> Hardwiring the version number in this manner is a real
maintenance
> drag.
> > > > >> Couldn't autogen.sh create a VERSION.AC file (or something
like it)
> > > > containing
> > > > >> only the version number that is just included here?
> > > > >
> > > > > I agree that it's essentially duplicated, but it's not that we
bump the
> > > > > version every day. To make sure there's no divergence, I added
a check
> > > > > that the one provided in AC_INIT and in VERSION are the same.
> > > > >
> > > > > Ideally, I'd like to get rid of the VERSION completely, but
apparently
> > > > > you can build the website without configure'ing the project. I
wasn't
> > > > > sure if that is still used, so I went for this solution.
> > > >
> > > > That doesn't answer my question, does it?
> > >
> > > Maybe I mis-understood your suggestion: I thought you're asking if
configure
> > can
> > > create a file that can be used in place of the current version.
> >
> > I have not written a word about "configure" in my question.  I asked
about
> > autogen.sh .
> >
> > > That doesn't
> > > work because "make website" can be called without configure'ing
(not sure if
> > > that is used, it's certainly different from how other projects
using the GNU
> > > build system works)
> > >
> > > But re-reading your question, you're maybe proposing to have a
file that is
> > > included by Autoconf when generating configure? I think that's not
possible
> > with
> > > the documented functionality of Autoconf because you can only do
very few
> > things
> > > before calling AC_INIT. I've not come across something that can
read a file
> in
> > > that situation.
> >
> > Shouldn't
> >
> > AC_INIT([LilyPond], include(`VERSION.AC'),
mailto:[address@hidden],
> > [lilypond], [http://lilypond.org/])
> >
> > work?

> Just putting that line to a configure.ac and running $ autoconf:
> configure.ac:1: warning: AC_INIT: not a literal: include(`VERSION.AC')

Oh, and the regardlessly generated configure doesn't expand the include.
In fact, it doesn't even care if the file exists, it just has
include(`VERSION.AC') in all places where I would expect the version.

https://codereview.appspot.com/549350043/