|
| From: | dak |
| Subject: | Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by address@hidden) |
| Date: | Sun, 08 Nov 2015 21:22:03 +0000 |
https://codereview.appspot.com/270640043/diff/20001/scm/stencil.scm File scm/stencil.scm (right): https://codereview.appspot.com/270640043/diff/20001/scm/stencil.scm#newcode76 scm/stencil.scm:76: (cons 0 0)) Why not '(0 . 0) here? It does not look like the cons is ever changed, so why a fresh cons for every use? https://codereview.appspot.com/270640043/diff/20001/scm/stencil.scm#newcode82 scm/stencil.scm:82: (interval-length (ordered-cons (car start) (car stop)))) you mean (abs (- (car start) (car stop))) here I presume. The difference of two x coordinates is not an "interval" and should not be treated as such. https://codereview.appspot.com/270640043/diff/20001/scm/stencil.scm#newcode85 scm/stencil.scm:85: (interval-length (ordered-cons (cdr start) (cdr stop)))) Same here. https://codereview.appspot.com/270640043/diff/20001/scm/stencil.scm#newcode88 scm/stencil.scm:88: (sqrt (+ (* width width) (* height height)))) Is there a reason you are actually taking the absolute values of width and height? You don't need them for calculating the length here. https://codereview.appspot.com/270640043/diff/20001/scm/stencil.scm#newcode100 scm/stencil.scm:100: (/ height length-to-print)))) This looks like a total mess. Do you even need all this for something? What are you trying to do? Perhaps express it in words and we'll try finding a direct representation that does not need all this juggling with angles and stuff. https://codereview.appspot.com/270640043/
| [Prev in Thread] | Current Thread | [Next in Thread] |