Re: Set X-parent of TextScript to NoteColumn instead of PaperColumn (issue 106640043 by address@hidden)

[janek . lilypond]

New patchset uploaded.


https://codereview.appspot.com/106640043/diff/20001/lily/note-column.cc
File lily/note-column.cc (right):

https://codereview.appspot.com/106640043/diff/20001/lily/note-column.cc#newcode169
lily/note-column.cc:169: if (head)
On 2014/07/11 11:10:10, dak wrote:
> Why would this test become required when it wasn't before?  Doesn't
this imply
> that you are now calling this function prematurely?

Good question; you may be right.  But i don't have any ideas why
LilyPond would call that function prematurely instead of waiting till
all necessary information is available.  In other words, why there were
no such problems with DynamicTexts?  If i had an example input on which
the code without this check fails, maybe i could figurre this out.

https://codereview.appspot.com/106640043/diff/20001/lily/text-engraver.cc
File lily/text-engraver.cc (right):

https://codereview.appspot.com/106640043/diff/20001/lily/text-engraver.cc#newcode34
lily/text-engraver.cc:34: struct Script_tuple
On 2014/07/11 11:10:10, dak wrote:
> Why?  You never exploit the connection between grob and event, so why
would you
> need to combine grobs and events in one array?

Because i didn't pay enough attention when i copied the code from
script_engraver.  Btw, script_engraver doesn't need such connection
either, shall i fix it in this issue or a separate one?

https://codereview.appspot.com/106640043/